Skip to content

Fix - Unpinned admin sidebar can remain expanded after cursor is moved out#4108

Open
VictorDuranEscire wants to merge 1 commit intoDSpace:mainfrom
VictorDuranEscire:dspace_3416
Open

Fix - Unpinned admin sidebar can remain expanded after cursor is moved out#4108
VictorDuranEscire wants to merge 1 commit intoDSpace:mainfrom
VictorDuranEscire:dspace_3416

Conversation

@VictorDuranEscire
Copy link
Copy Markdown
Contributor

Hi @tdonohue, I'am @jtimal partner, I like to share this PR with you.

References

Description

I have made a change to modify the current function in the side navigation admin component to collapse the navigation if the mouse leaves the component

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • I have changed the current function when the mouse is left on the navigation component on the administrator side and automatically collapse the menu without validating the focus settings

To reproduce:

  1. Log in for the admin sidebar to show up
  2. Hover over the sidebar until it expands
  3. Open at least one expandable menu section
  4. Move the cursor out of the sidebar, but don't click anywhere so it doesn't lose focus

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge ux User Experience related works port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Mar 24, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 9.0 Release Mar 24, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release May 19, 2025
@pzlakowski
Copy link
Copy Markdown

pzlakowski commented Feb 27, 2026

I have checked this PR and introduces a new problem.

Case 1. Correct one

  1. Move cursor at menu, it will expand
  2. Move outside the menu, it will collapse
  3. Move cursor at menu, it will expand once again correctly

Case 2. Invalid one

  1. Move cursor at menu, it will expand
  2. Click at any menu item to trigger focus
  3. Move outside the menu, it will collapse
  4. Move cursor at menu, it will not expand
    • You must click outside the menu area to bring expand functionality back

I have recorded it:

Screen.Recording.2026-02-27.at.13.49.23.mov

This happens because value of inFocus$ observable stays true when you collapse the menu.

@tdonohue tdonohue moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 10.0 Release Feb 27, 2026
@lgeggleston lgeggleston added the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release ux User Experience related works

Projects

Status: 👀 Under Review

Development

Successfully merging this pull request may close these issues.

Unpinned admin sidebar can remain expanded after cursor is moved out

4 participants